Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-600] Feature/avatar template element #164

Merged
merged 14 commits into from
Nov 29, 2023

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Nov 27, 2023

SDK-600

Description

  • This PR includes a TemplateAvatar element that can be used to display avatar template icons and fire an event with the required data. It also includes a ButtonElement class which should be usable in other cases.
  • it has I realize that we already have Asset and Avatar button classes in the sample but I wanted to keep this separate so as not to break the sample but also I think these simpler elements might be more re-usable. We can always update later as needed.

How to Test

  • easiest way to test is to checkout the feature/template-avatar-element branch in Unity-SDK repo and run the test scene in the TEMP folder. You should be able to:
  1. run the scene
  2. see the template buttons load
  3. click a button
  4. see selected icon
  5. check console for print out on avatar ID and gender

image

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team as a code owner November 27, 2023 07:16
@HarrisonHough HarrisonHough changed the title Feature/avatar template element [SDK-600] Feature/avatar template element Nov 27, 2023
Copy link
Contributor

@rYuuk rYuuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Nice work, I nit-picked a bit😅. Please let me know if the concerns are valid or not.

Runtime/AvatarCreator/Data/AssetLibrary.cs Show resolved Hide resolved
Runtime/AvatarCreator/Data/AssetLibrary.cs Outdated Show resolved Hide resolved
Runtime/AvatarCreator/TemplateFetcher.cs Outdated Show resolved Hide resolved
Runtime/AvatarCreator/UI/Buttons/ButtonElement.cs Outdated Show resolved Hide resolved
Runtime/AvatarCreator/UI/Elements/TemplateAvatarElement.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@rYuuk rYuuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Thanks for making the changes.

@HarrisonHough HarrisonHough merged commit 0c5e5a2 into develop Nov 29, 2023
@HarrisonHough HarrisonHough deleted the feature/avatar-template-element branch November 29, 2023 07:13
rYuuk pushed a commit that referenced this pull request Nov 29, 2023
- added avatar template element and other required logic and classes + prefabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants