Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-623] feat: update api to work with GLTFast 6.0 #157

Merged
merged 4 commits into from
Nov 21, 2023
Merged

[SDK-623] feat: update api to work with GLTFast 6.0 #157

merged 4 commits into from
Nov 21, 2023

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Nov 20, 2023 •
edited by jira bot
Loading

SDK-623

Description

  • This PR includes updates to support GLTF 6.0 it is a breaking change and it seems there isn't an elegant way to add or handle backwards compatibility.

How to Test

  • Importy gltfast 6.0 and our SDK (this branch) everything should work without errors

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team as a code owner November 20, 2023 05:20
rk132
rk132 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@rk132 rk132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small question.

Runtime/GLTF/GltFastGameObjectInstantiator.cs Outdated Show resolved Hide resolved
@HarrisonHough HarrisonHough merged commit 5088225 into develop Nov 21, 2023
@HarrisonHough HarrisonHough deleted the feature/gltf-6 branch November 21, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rk132 rk132 rk132 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarrisonHough @rk132