Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-622] Feature/unity gltfast #155

Merged
merged 4 commits into from
Nov 20, 2023
Merged

[SDK-622] Feature/unity gltfast #155

merged 4 commits into from
Nov 20, 2023

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Nov 17, 2023 •
edited
Loading

SDK-622

Description

  • Gltfast can now be added by package name and set as a dependency (not using git repository). As such we no longer need to force install it ourselves which will also help us improve the install process.

How to Test

  • install RPM core as before by git URL (this branch) and observe behaviour but everything should work

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team as a code owner November 17, 2023 06:59
@rYuuk
Copy link
Contributor

rYuuk commented Nov 20, 2023

image

@HarrisonHough HarrisonHough merged commit ac4adb9 into develop Nov 20, 2023
4 checks passed
@HarrisonHough HarrisonHough deleted the feature/unity-gltfast branch November 20, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxAndreassenRPM MaxAndreassenRPM MaxAndreassenRPM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarrisonHough @rYuuk @MaxAndreassenRPM