Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-513] Add appid to setup guide #145

Merged
merged 2 commits into from
Nov 13, 2023
Merged

[SDK-513] Add appid to setup guide #145

merged 2 commits into from
Nov 13, 2023

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Nov 6, 2023 •
edited by jira bot
Loading

SDK-513

Description

  • Added app id to setup guide

How to Test

  • Import package and open setup guide

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk self-assigned this Nov 6, 2023
@rYuuk rYuuk requested a review from a team as a code owner November 6, 2023 14:59
HarrisonHough
HarrisonHough approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, but is the appID supposed to have a red error icon next to it if it's not set?
It might be weird that you block the next button but don't highlight the field with the problem like we do with subdomain
image

@rYuuk rYuuk merged commit 3a1e8a3 into develop Nov 13, 2023
@rYuuk rYuuk deleted the feature/setup-guide-app-id branch November 13, 2023 12:00
HarrisonHough pushed a commit that referenced this pull request Nov 29, 2023
@rYuuk @HarrisonHough
[SDK-513] Add appid to setup guide (#145)
9bd56b8 
## [SDK-513](https://ready-player-me.atlassian.net/browse/SDK-513)

## Description

- Added app id to setup guide
@HarrisonHough HarrisonHough mentioned this pull request Nov 29, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees

@rYuuk rYuuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rYuuk @HarrisonHough