Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-376] Add mesh opt import #144

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Nov 2, 2023

SDK-376

Description

  • Refactored AvatarConfigEditor with ui toolkit

How to Test

  • Try different avatar config options and load avatar in a new project

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk self-assigned this Nov 2, 2023
@rYuuk rYuuk requested a review from a team as a code owner November 2, 2023 12:57
@rYuuk rYuuk changed the base branch from main to develop November 2, 2023 12:57
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good and the auto import seems to work.
I would say that the UI layout for avatar config could be improved slightly, like lining up the compression checkboxes. And expanding the texture channel stuff so that there is no need to scroll (if possible).
But these are minor and non-blocking for me. We could always make a separate low-priority task for this if we want.
image

@rYuuk rYuuk merged commit ee4bd9e into develop Nov 3, 2023
4 checks passed
@rYuuk rYuuk deleted the feature/mesh-opt-installation branch November 3, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants