Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-579] feat: merged related samples #139

Merged
merged 2 commits into from
Oct 30, 2023
Merged

[SDK-579] feat: merged related samples #139

merged 2 commits into from
Oct 30, 2023

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Oct 27, 2023 •
edited by jira bot
Loading

SDK-579

Description

  • merged the multiple loading and render samples into there own folders.

How to Test

  • Add steps to locally test these changes

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team as a code owner October 27, 2023 09:12
rYuuk
rYuuk approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@rYuuk rYuuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Imported samples and tested all them.
image

@HarrisonHough HarrisonHough merged commit dc7848f into develop Oct 30, 2023
@HarrisonHough HarrisonHough deleted the feature/sample-merge branch October 30, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rYuuk rYuuk rYuuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarrisonHough @rYuuk