Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/dont replace existing avatar on load #138

Merged
merged 16 commits into from
Oct 26, 2023
Merged

Feature/dont replace existing avatar on load #138

merged 16 commits into from
Oct 26, 2023

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented Oct 25, 2023 •
edited by jira bot
Loading

SDK-560

Description

  • Don't destroy avatar, when avatar with same id exists in the scene

How to Test

  • Load avatar twice and observe, that the avatar is not destroyed

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

rYuuk and others added 16 commits October 24, 2023 14:13
@rk132 rk132 marked this pull request as ready for review October 25, 2023 13:25
@rk132 rk132 requested a review from a team as a code owner October 25, 2023 13:25
HarrisonHough
HarrisonHough approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, great stuff!

@rk132 rk132 merged commit 28ba53f into develop Oct 26, 2023
@rk132 rk132 deleted the feature/dont-replace-existing-avatar-on-load branch October 26, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rk132 @HarrisonHough @rYuuk