Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/blend images #8

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Feat/blend images #8

merged 6 commits into from
Dec 7, 2023

Conversation

TechyDaniel
Copy link
Contributor

@TechyDaniel TechyDaniel commented Dec 6, 2023

Description

  • Image blending feature added

Fixes # (issue)

  • enforcing the user to use same color mode canvas and colors.

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x ] This change requires a documentation update

How Has This Been Tested?

Unit tests

Checklist

  • [x ] I confirm that the changes meet the user experience and goals outlined in the design plan (if there is one).
  • [x ] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] I have updated any version info, if necessary.
  • [ x] My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes

Task: TECHART-332

@TechyDaniel TechyDaniel self-assigned this Dec 6, 2023
@TechyDaniel TechyDaniel marked this pull request as ready for review December 6, 2023 14:15
Copy link
Collaborator

@Olaf-Wolf3D Olaf-Wolf3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix failing test

src/readyplayerme/meshops/draw/rasterize.py Show resolved Hide resolved
src/readyplayerme/meshops/draw/rasterize.py Outdated Show resolved Hide resolved
src/readyplayerme/meshops/image.py Show resolved Hide resolved
src/readyplayerme/meshops/image.py Outdated Show resolved Hide resolved
src/readyplayerme/meshops/image.py Show resolved Hide resolved
- Add tests for non-uniform mask values in blend_images.
- Include RGB images blending tests.
- Handle edge cases and exception scenarios.
- Cover different image sizes and empty masks.
@TechyDaniel TechyDaniel marked this pull request as draft December 6, 2023 18:27
@TechyDaniel TechyDaniel marked this pull request as ready for review December 6, 2023 18:28
@Olaf-Wolf3D Olaf-Wolf3D marked this pull request as draft December 7, 2023 10:51
@Olaf-Wolf3D Olaf-Wolf3D marked this pull request as ready for review December 7, 2023 10:51
@Olaf-Wolf3D Olaf-Wolf3D merged commit 9101a0d into main Dec 7, 2023
1 check passed
@Olaf-Wolf3D Olaf-Wolf3D deleted the feat/blend-images branch December 7, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants