feat: update uv_to_texture_space function #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the function to handle edge cases and improve tests.
Olaf-Wolf3D
requested changes
Nov 16, 2023
Olaf-Wolf3D
requested changes
Nov 17, 2023
- need to find a way to accept test results with 1 px tolerance
Olaf-Wolf3D
requested changes
Nov 21, 2023
Co-authored-by: Olaf Haag <[email protected]>
Co-authored-by: Olaf Haag <[email protected]>
TechyDaniel
commented
Nov 21, 2023
- Add function to convert UV coordinates to texture space pixel coordinates. - Ensure correct handling of edge cases including wrapping of out-of-range UVs. - Include comprehensive tests to validate functionality across various scenarios.
Olaf-Wolf3D
requested changes
Nov 23, 2023
- now if the indices are none it creates a list of the length of UVs and selects them all. - added a test for 0 px image.
func now called uv_to_image_coords, removed unnecessary code
Olaf-Wolf3D
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the uv_to_texture_space function, designed to convert UV coordinates to texture space coordinates. The function is capable of handling specific vertex indices or processing all vertices in the mesh. It includes robust validation checks to handle out-of-range UV coordinates, ensuring that UV coordinates are within the standard [0, 1] range. Additionally, the PR includes a comprehensive suite of unit tests to validate the functionality of this new function under various scenarios.
Type of change
How Has This Been Tested?
The updated function was tested with a series of new unit tests that were added to the existing test suite. These tests include scenarios where UV coordinates are out of the standard range and where indices do not have corresponding UVs. All tests pass, confirming the correctness of the changes.
Test Configuration:
Tests were performed using the project's standard test environment.
Checklist