-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: tests and fixtures #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tests for get_edges_from_mesh and border vertex extraction. - Introduce mock_data.py for consistent mock usage. - Refactor get_border_vertices to take an array instead of a mesh.
Olaf-Wolf3D
reviewed
Nov 14, 2023
Olaf-Wolf3D
reviewed
Nov 14, 2023
Olaf-Wolf3D
reviewed
Nov 14, 2023
Olaf-Wolf3D
reviewed
Nov 14, 2023
Olaf-Wolf3D
reviewed
Nov 14, 2023
Olaf-Wolf3D
reviewed
Nov 14, 2023
Olaf-Wolf3D
reviewed
Nov 14, 2023
Olaf-Wolf3D
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's butcher this PR for a learning experience! :D
mesh protocol, test dir structure, fixtures, function name
Olaf-Wolf3D
changed the title
feat: add get_edges_from_mesh to extract edges from mesh
refactor!: tests and fixtures
Nov 15, 2023
Olaf-Wolf3D
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We now accept edges as input into the get_boundary_vertices.
Those vertices are extracted in a different function which is designed to work regardless of the mesh data structure input.
Task: TECHART-323
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration:
Checklist