-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!feat: add blend_uv_seams #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split color mode funcs to prevent circular imports. Load all functions in draw into its namespace for brevity. --------- Co-authored-by: Daniel-Ionut Rancea <[email protected]>
move color funcs from mesh to colors. move rasterize funcs into image.
TechyDaniel
previously approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested :
overall performance :
0.664 main mytester.py:517
├─ 0.406 blend_uv_seams draw\image.py:253
│ ├─ 0.340 rasterize draw\image.py:195
│ │ ├─ 0.209 draw_lines draw\image.py:158
│ │ │ ├─ 0.112 __getattr__ lazy_loader\__init__.py:72
│ │ │ │ [4 frames hidden] lazy_loader, importlib, <built-in>
│ │ │ ├─ 0.041 interpolate_values draw\color.py:89
│ │ │ │ └─ 0.038 [self] draw\color.py
│ │ │ ├─ 0.034 [self] draw\image.py
│ │ │ └─ 0.018 line skimage\draw\draw.py:353
│ │ ├─ 0.087 lerp_nans_horizontally draw\image.py:126
│ │ │ └─ 0.087 apply_along_axis numpy\lib\shape_base.py:267
│ │ │ [2 frames hidden] numpy
│ │ │ 0.076 interpolate_segment draw\image.py:94
│ │ │ ├─ 0.029 [self] draw\image.py
│ │ │ ├─ 0.026 interp numpy\lib\function_base.py:1461
│ │ │ │ [2 frames hidden] numpy, <built-in>
│ │ │ └─ 0.012 any numpy\core\fromnumeric.py:2322
│ │ │ [2 frames hidden] numpy
│ │ └─ 0.043 clip_image draw\image.py:36
│ │ ├─ 0.021 [self] draw\image.py
│ │ ├─ 0.015 nan_to_num numpy\lib\type_check.py:403
│ │ └─ 0.008 clip numpy\core\fromnumeric.py:2100
│ │ [3 frames hidden] numpy
│ ├─ 0.030 blend_images draw\image.py:64
│ ├─ 0.017 gaussian_filter scipy\ndimage\_filters.py:280
│ │ [4 frames hidden] scipy, <built-in>
│ └─ 0.009 [self] draw\image.py
├─ 0.197 Image.save PIL\Image.py:2328
│ [8 frames hidden] PIL, <built-in>
│ 0.185 ImagingEncoder.encode <built-in>
└─ 0.058 read_mesh mesh.py:28
└─ 0.058 read_gltf mesh.py:46
├─ 0.050 load trimesh\exchange\load.py:71
│ [11 frames hidden] trimesh, PIL, <built-in>
└─ 0.008 from_trimesh_material material.py:31
👍
…ctor defaults truth value was ambiguous
UVs are not loaded if there's no material
Mesh was just a protocol before.
UVs are all (0.5, 0.5). Limitation of trimesh.
material was added to simple gltf previously, breaking this test.
add necessary functions and tests in mesh and image to create UV masks.
covers a previous bug-fix.
Test passes on Windows locally, but fails in github action.
tests pass locally on Windows and WSL Ubuntu, but fail on github action.
The integration test and unit tests for RGB and RGBA images pass locally on Windows and WSL Ubuntu, but fail on the github action. Skipping those tests for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split color mode funcs to prevent circular imports. Load all functions in draw into its namespace for brevity.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.
Test Configuration:
Checklist
Task: Techart-334