Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added image extraction #11

Merged
merged 9 commits into from
Dec 13, 2023
Merged

feat: Added image extraction #11

merged 9 commits into from
Dec 13, 2023

Conversation

TechyDaniel
Copy link
Contributor

@TechyDaniel TechyDaniel commented Dec 11, 2023

Description

Added image extraction from a trimesh.mesh that is within a .glb file

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x ] This change requires a documentation update

How Has This Been Tested?

  • added 1 integrational test since most of the functions are not proprietary.

Checklist

  • [x ] I confirm that the changes meet the user experience and goals outlined in the design plan (if there is one).
  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [x ] I have updated any version info, if necessary.
  • [x ] My changes generate no new warnings
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes

Task: TECHART-327

…b file

- added 1 integrational test since most of the functions are not propiertary.
@TechyDaniel TechyDaniel self-assigned this Dec 11, 2023
@TechyDaniel TechyDaniel marked this pull request as ready for review December 11, 2023 20:03
@TechyDaniel TechyDaniel marked this pull request as draft December 11, 2023 20:03
@TechyDaniel TechyDaniel marked this pull request as ready for review December 11, 2023 20:03
@TechyDaniel TechyDaniel marked this pull request as draft December 12, 2023 09:19
@TechyDaniel TechyDaniel marked this pull request as ready for review December 12, 2023 09:19
@TechyDaniel TechyDaniel marked this pull request as draft December 12, 2023 09:25
@TechyDaniel TechyDaniel marked this pull request as ready for review December 12, 2023 09:25
@TechyDaniel TechyDaniel marked this pull request as draft December 12, 2023 09:34
@TechyDaniel TechyDaniel marked this pull request as ready for review December 12, 2023 09:34
@TechyDaniel TechyDaniel marked this pull request as draft December 12, 2023 09:41
@TechyDaniel TechyDaniel marked this pull request as ready for review December 12, 2023 09:42
Olaf Haag added 4 commits December 13, 2023 00:52
material class that can instantiate from a trimesh material. Converts PIL.Image to internal Image type.
also remove get diffuse color func in favor of material class.
add uv and material attribute

mesh type now in mesh.py
@Olaf-Wolf3D Olaf-Wolf3D marked this pull request as draft December 13, 2023 10:55
@Olaf-Wolf3D Olaf-Wolf3D marked this pull request as ready for review December 13, 2023 10:55
@Olaf-Wolf3D Olaf-Wolf3D merged commit 1fefb55 into main Dec 13, 2023
1 check passed
@Olaf-Wolf3D Olaf-Wolf3D deleted the feat/extract-diffuse branch December 13, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants