Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/coverage-report #10

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix/coverage-report #10

merged 2 commits into from
Dec 12, 2023

Conversation

Olaf-Wolf3D
Copy link
Collaborator

@Olaf-Wolf3D Olaf-Wolf3D commented Dec 11, 2023

Description

Create HTML coverage report in ./tests/.coverage.
Add .coverage folder next to .profiles folder to the CI artifact.
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

  • ran hatch run test locally, checked tests/coverage

Test Configuration:

  • Did you use the test environment provided by the project (e.g. a hatch action)?
    yes

Checklist

  • I confirm that the changes meet the user experience and goals outlined in the design plan (if there is one).
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have updated any version info, if necessary.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Task: TECHART-340, TECHART-341

Olaf Haag added 2 commits December 11, 2023 20:04
Do not show tests themselves in the coverage report. Show files that are not covered by tests at all.

Task: TECHART-340
add folder with HTML coverage reports to the artifact

Task: TECHART-341
@Olaf-Wolf3D Olaf-Wolf3D self-assigned this Dec 11, 2023
@Olaf-Wolf3D Olaf-Wolf3D marked this pull request as ready for review December 11, 2023 19:45
@Olaf-Wolf3D Olaf-Wolf3D merged commit 2300dcb into main Dec 12, 2023
1 check passed
@Olaf-Wolf3D Olaf-Wolf3D deleted the fix/coverage-report branch December 12, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants