feat(ruby): upgrade versions & dependencies #1067
Conversation
| @@ -134,5 +128,17 @@ def host_header | |||
| 'Host' => @request.host | |||
| }.compact | |||
| end | |||
|
|
|||
| def read_body(io) | |||
There was a problem hiding this comment.
@AndriiAndreiev what's the context behind this method?
There was a problem hiding this comment.
In short, the logic under the hood changed, and it stopped working the way it used to. The problem appears when we have empty request bodies. In this case, we call the “read” method from nil, which leads to errors. And because of this, 2 tests stopped working.
There was a problem hiding this comment.
I didn't find any exact solutions for this, but this method seems to fix it
There was a problem hiding this comment.
@AndriiAndreiev can you add a test case for this? Looks good to me, but I'd love some additional confidence in our code base.
| # commit-message: | ||
| # prefix: chore(deps) | ||
| # prefix-development: chore(deps-dev) | ||
| - package-ecosystem: bundler |
There was a problem hiding this comment.
nit: might be mistaken, but I don't believe this is related to the other changes. If not, given we squash and merge commits from PRs, maybe let's move this to a separate PR so we have a more distinct commit history post-merge.
|
@AndriiAndreiev can you resolve conflicts here? Happy to merge after. |
🧰 Changes