chore(node): removing our dependency on oas

[erunion]

🧰 Changes

I don't totally understand why we're loading oas in for types on the getGroupIdByOperation method that by all accounts seems to be unused, but because the version of oas we are using is pretty old I'm upgrading it.

Because oas is currently being used solely for getGroupIdByOperation, a method that is not being used anywhere, I am removing getGroupIdByOperation and our oas dependency.

[kanadgupta]

yeah i just confirmed that getGroupIdByOperation isn't being used anywhere — i say we get rid of it and uninstall oas 🚮

@mjcuva any context on this?

[mjcuva]

I think this was added by @jamestclark! Here's the comments from the initial pr when this was added: https://github.com/readmeio/metrics-sdks/pull/879/files#r1454075743

[kanadgupta]

ah thanks! re: this comment:

And yeah it's not used directly by the metrics SDK. As the code is very similar to what we already had in the main codebase he idea here is to co-locate all the securityRequirements code here and have the main codebase use this once it's published.

my general take is that because the readmeio package is used by customers, we should only export functions that are useful to end users when possible (as opposed to functions that are exclusively for ReadMe internal use). i also just checked and i can't seem to find any instances of getGroupIdByOperation in our main codebase either. does anybody have qualms about us getting rid of this?

[erunion]

kind of agree that we should only keep things that will be used in the sdk within the sdk. i'm going to pull getGroupIdByOperation and oas entirely.