feat(sdk-snippets): library modernization with ESM+CJS builds #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
reviewed
Jun 17, 2024
|
Given that this package is really only used in our main codebase, is this PR necessary? Historically we've really only done this dual-export thing for packages that are used by |
|
Not really I guess. I'll close it out |
|
@kanadgupta I'm remembering now that the reason I did this was to upgrade to the latest release of |
yep, agreed with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This modernizes our
sdk-snippetslibrary in order to now export CJS and ESM dist builds.🧬 QA & Testing
Running
npm run attwall of the types for this new library output line up as expected: