Final code review #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added top-5 feature
added 24hour currency volum feature
Module that simplifies working with api
Api module
This reverts commit 1a3bd3a.
Пофиксил строку длиною больше 80 символов, заменил if else на тернарный оператор
Фикс CRLF, длинны строки через изменение названий переменных. Запрос к readline теперь один.
24h volume feature
Добавил функцию сохранения результата в текстовый файл
Функция сохранение результатов в текстовый файл
Несколько комментариев, враппер для добавления функциям обработки ошибок колбеком handleError, враппер и функция writeFile добавлены в экспорт
…yToCrypto(crypto.js)
…iveCurrencies(crypto.js)
Unit testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.