Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
readeral committed Aug 27, 2018
2 parents 745b322 + 55a5dc7 commit d1f671a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,7 @@ You receive unadulterated event data from the Nuimo for all these actions, with
### Known issues yet to be fixed
- Currently node-red needs to be stopped and restarted if the latest deploy was a 'full' deploy, due to the config node (which maintains the bluetooth connection) not cleaning up properly. **To get around this problem on the regular, make use of the Modified Flows deployment option**, unless you've made changes to the config node, in which case you'll have to restart Node Red. (N.b This is related to an [outstanding pull request on the Noble BLE library](https://github.com/noble/noble/pull/577), so likely won't be resolved until it is merged )
- If activeApp (in the global context) is updated programatically rather than through the Nuimo controller, then you lose the ability to bring up the app switcher. Until this is resolved, avoid changing that variable via function nodes.

### Contribution guide
As this is a new project, the only pull requests that will be considered are updates to the documentation, minor error fixes in the code, and minor feature enhancements (like matrix array preset options)
As I'm a relatively new javascript developer, requests for refactoring with promises/async/await etc. will require significant explanation of the benefits for the change if a pull request is to be considered. specific use cases applicable to your unique project will probably be unlikely to be considered for inclusion. rewriting in typescript is out of the question at this stage (i dont have time to learn it. Requests for tests are warmly encouraged, pending a discussion on a suitable testing approach.

0 comments on commit d1f671a

Please sign in to comment.