Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: position of browse and create buttons #1424 #1463

Merged
merged 14 commits into from
Feb 19, 2024
Merged

fix: position of browse and create buttons #1424 #1463

merged 14 commits into from
Feb 19, 2024

Conversation

clevercoderjoy
Copy link
Contributor

@clevercoderjoy clevercoderjoy commented Feb 18, 2024

Description

Fixed the overlapping create and browse buttons in the footer section for all small and medium-sized devices.

Fixes #1424

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Screenshots or example output

image
image

Copy link

netlify bot commented Feb 18, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit a867776
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65d2387b83bfb500089e1803
😎 Deploy Preview https://deploy-preview-1463--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also there are few formatting issue please fix

src/common/footer/ExtendedFooter.jsx Outdated Show resolved Hide resolved
@priyankarpal priyankarpal added the changes required need to change some thing label Feb 18, 2024
@priyankarpal priyankarpal changed the title Fixed the position of browse and create buttons/1424 fix: position of browse and create buttons #1424 Feb 18, 2024
@priyankarpal priyankarpal added ready to merge 🛠 goal: fix Bug fix and removed changes required need to change some thing labels Feb 18, 2024
@priyankarpal priyankarpal added changes required need to change some thing and removed ready to merge labels Feb 18, 2024
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉 I also suggest keeping branch names short and clear.
example fix-issue-1424

@priyankarpal priyankarpal added ready to merge and removed changes required need to change some thing labels Feb 19, 2024
@priyankarpal priyankarpal merged commit d323ed5 into reactplay:main Feb 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: UI Issues in various small and medium sized devices
2 participants