Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): focus fix on play filter modal open #1415

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

hjaintech
Copy link
Collaborator

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1414 (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Yes. When you open the filter plays modal now, the focus will be on the first element inside the modal by default. Also, when you close the modal, the focus would go back to the button which opens this modal.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Copy link

netlify bot commented Dec 24, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit a5a456a
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6589caaa2eb20800087efd7d
😎 Deploy Preview https://deploy-preview-1415--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

priyankarpal
priyankarpal previously approved these changes Dec 25, 2023
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@hjaintech
Copy link
Collaborator Author

Looks Good 🎉

@priyankarpal Fixed both of your comments. Can you approve again please?

@priyankarpal
Copy link
Member

Looks Good 🎉

@priyankarpal Fixed both of your comments. Can you approve again please?

done ✅ Thank you

@atapas atapas merged commit c387759 into reactplay:main Jan 3, 2024
4 checks passed
@hjaintech hjaintech deleted the focus_fix branch January 3, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Focus doesn't come on first element of the modal when Filter plays modal is opened
3 participants