Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1408 tip calculator design #1411

Closed

Conversation

ehasanrobin
Copy link

@ehasanrobin ehasanrobin commented Dec 18, 2023

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for reactplayio failed.

Name Link
🔨 Latest commit 68489d2
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6581508767c618000857fc9d

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@ehasanrobin
Copy link
Author

design issue fixed and also state is updating

@priyankarpal priyankarpal added waiting for reviewers no issue number no issue number, we can't merge the PR changes required need to change some thing labels Dec 21, 2023
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some errors, please check
image

@priyankarpal
Copy link
Member

Could you please add the issue number, even though it has already been assigned to someone?

@priyankarpal
Copy link
Member

there no updates for 2 weeks so we have to close the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required need to change some thing no issue number no issue number, we can't merge the PR waiting for reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants