Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plays): add Dice Simulator play to the project #1394

Merged
merged 7 commits into from
Dec 15, 2023

Conversation

Roassaf
Copy link
Contributor

@Roassaf Roassaf commented Nov 23, 2023

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Add play Dice Simulator, a plataform where you can simulate dice so that you can play RPGs or other games

Fixes #1342

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I ran this locally and checked if the play works

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots or example output

image

Copy link

netlify bot commented Nov 23, 2023

👷 Deploy request for reactplayio pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6faa830

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

src/plays/dice-simulator/Readme.md Outdated Show resolved Hide resolved
@priyankarpal priyankarpal added the changes required need to change some thing label Nov 28, 2023
@priyankarpal
Copy link
Member

hello @Roassaf would you like to update us?

@Roassaf
Copy link
Contributor Author

Roassaf commented Dec 3, 2023

hello @Roassaf would you like to update us?

Hi @priyankarpal, I will fix the readme this week

@priyankarpal
Copy link
Member

hello @Roassaf would you like to update us?

Hi @priyankarpal, I will fix the readme this week

cool

@priyankarpal
Copy link
Member

@Roassaf I would like to suggest that when you push your changes, you create a separate branch.

image

@priyankarpal priyankarpal merged commit 283066f into reactplay:main Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add a Play]: Dice Simulator
3 participants