Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove umani script from index.html as it is not used since some month #1339

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

Angra974
Copy link
Contributor

@Angra974 Angra974 commented Oct 15, 2023

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

We have an api call made for analystic with Umani.
This one is not use since Mai 2023 ( when looking at last projects ) and certainly before this.

The environment variable was removed some time ago too.

current .env.development file =>
Capture d’écran du 2023-10-15 09-08-12

@atapas is ok to remove this as it's a know issue.

Fixes #1295

Type of change

Just remove the javascript code in the public/index.html file

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Run the application on multiple page to see if the api is called or not.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Load the application and check inside the debugger if the api is called.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

From Mai 2033 ( index.html in public folder ):
Capture d’écran du 2023-10-15 08-55-35

Before change =>
The api is called and create a js error
before

After change => No api call, no error related
after

@netlify
Copy link

netlify bot commented Oct 15, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit d18ba67
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/652b7428dbd1760008fbbd2b
😎 Deploy Preview https://deploy-preview-1339--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@Angra974 Angra974 self-assigned this Oct 15, 2023
@atapas atapas merged commit 64349ec into main Oct 16, 2023
5 of 6 checks passed
@atapas atapas deleted the issue_1295_umani_api branch October 16, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants