Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hangman Game is Developed and tested #1313

Merged
merged 9 commits into from
Oct 12, 2023
Merged

Hangman Game is Developed and tested #1313

merged 9 commits into from
Oct 12, 2023

Conversation

ANKITy102
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
I have developed and thoroughly tested the Hangman game, and it's fully functional and ready for review.

Game Features:

  • Hint Display: Users are presented with a hint for the word they need to guess.
  • Word Guessing: Users are required to guess the word based on the given hint.
  • Incorrect Guess Handling: Incorrect guesses lead to the gradual creation of the hangman figure.
  • Loss Condition: If the hangman figure is completed, the user loses the game.
  • Win Condition: Upon successful completion, the user can reset the game and receive a new word to guess.

I have used styed components to build the components efficiently and responsive. So styled-components library is installed. No other libraries are installed.

Fixes #1297

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • All the prettier checks are passed. I used standard to avoid prettier errors.
  • Code is also tested by the linter.
  • I have run the application on the React-Play site and it is working fine.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Screenshots or example output

Screenshot 2023-10-07 001903
Screenshot 2023-10-07 001924
Screenshot 2023-10-07 001936
Screenshot 2023-10-07 001959

@ANKITy102
Hangman Game is Developed and tested
9a2d4c0 
This game include to guess the user a word using the hint provided. With each wrong guess, a part of the hangman figure appears. If complete hangman is formed then user loses the game. After completion of game, user can get the new word to guess by clicking reset game.
@netlify
Copy link

netlify bot commented Oct 6, 2023 •
edited
Loading

✅ Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 2b7e383
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6526ff1ce9c3cf0008f947ff
😎 Deploy Preview https://deploy-preview-1313--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 6, 2023

@ANKITy102 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@ANKITy102
Copy link
Contributor Author

@joshi-kaushal

Could you please review my changes and pr.

sudipkundu999
sudipkundu999 suggested changes Oct 7, 2023
View reviewed changes
src/plays/hangman-game/components/Keyboard.tsx Outdated Show resolved Hide resolved
src/plays/hangman-game/components/Keyboard.tsx Outdated Show resolved Hide resolved
src/plays/hangman-game/components/Main.tsx Outdated Show resolved Hide resolved
src/plays/hangman-game/components/wordList.json Outdated Show resolved Hide resolved
src/plays/hangman-game/styles.css Show resolved Hide resolved
@ANKITy102
All the necessory changes are done
357dd74 
Constants, styled components, Jsx components are now separated
@ANKITy102
Copy link
Contributor Author

@sudipkundu999

I've implemented the requested changes and am now eagerly awaiting your feedback.
Would you kindly review my revisions?

sudipkundu999
sudipkundu999 suggested changes Oct 7, 2023
View reviewed changes
src/plays/hangman-game/components/Main.tsx Outdated Show resolved Hide resolved
src/plays/hangman-game/constants/constants.tsx Outdated Show resolved Hide resolved
src/plays/hangman-game/components/Main.tsx Outdated Show resolved Hide resolved
@ANKITy102
Copy link
Contributor Author

@sudipkundu999

Thank you for your valuable feedback and guidance. I have incorporated your suggestions and pushed the necessary commits. Your continued input is greatly appreciated.

@sudipkundu999
Copy link
Contributor

LGTM!
@priyankarpal can you please deploy?

@priyankarpal
Copy link
Member

LGTM!
@priyankarpal can you please deploy?

I don't have access of vercel

@sudipkundu999
Copy link
Contributor

LGTM!
@priyankarpal can you please deploy?

I don't have access of vercel

Netlify?

@priyankarpal
Copy link
Member

LGTM!
@priyankarpal can you please deploy?

I don't have access of vercel

Netlify?

no

@ANKITy102
Copy link
Contributor Author

@joshi-kaushal
Could you please review and consider merging my pull request? Thank you!

@ANKITy102
Copy link
Contributor Author

@priyankarpal
Could you please review and consider merging my pull request? Thank you!

@priyankarpal
Copy link
Member

@priyankarpal Could you please review and consider merging my pull request? Thank you!

we will do it soon.

priyankarpal
priyankarpal previously approved these changes Oct 8, 2023
View reviewed changes
@atapas
Copy link
Member

atapas commented Oct 10, 2023

@ANKITy102 On it.

@atapas
Copy link
Member

atapas commented Oct 10, 2023

@sudipkundu999 I see you had requested changes. Could you please complete your review and if done, let's approve it.

atapas
atapas previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me.

sudipkundu999
sudipkundu999 suggested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@sudipkundu999 sudipkundu999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix these styling issues

  • The try again button does not look like it

    image

  • The hangman figure has some styling issues

    image

@atapas
Copy link
Member

atapas commented Oct 11, 2023

@ANKITy102 any update?

@ANKITy102
Copy link
Contributor Author

@ANKITy102 any update?

@atapas I am having some stuff to complete. But I will fix the styling issue tonight without any delay. Sorry for the delay.

@ANKITy102 ANKITy102 dismissed stale reviews from priyankarpal and atapas via 2b7e383 October 11, 2023 20:01
@ANKITy102
Copy link
Contributor Author

@atapas
I have fixed the styling issue. Below is the image for the same.

Fixed hangman figure styling issue

image

Fixed restart icon style

image

atapas
atapas approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styles changes are looking good.

@sudipkundu999 please check.

sudipkundu999
sudipkundu999 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@sudipkundu999 sudipkundu999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🚀

@atapas atapas merged commit 7a216fe into reactplay:main Oct 12, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atapas atapas atapas approved these changes

@priyankarpal priyankarpal priyankarpal approved these changes

@sudipkundu999 sudipkundu999 sudipkundu999 approved these changes

Assignees

@ANKITy102 ANKITy102

Labels
hacktoberfest hacktoberfest-accepted hacktoberfest-accepted play request New Play Request. waiting for reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Add a Play]: Hangman Game
4 participants
@ANKITy102 @sudipkundu999 @priyankarpal @atapas