Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] : custom scroll bar #1294

Merged
merged 9 commits into from
Oct 10, 2023
Merged

[Feature] : custom scroll bar #1294

merged 9 commits into from
Oct 10, 2023

Conversation

letscodedanish
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

This PR add a new feature of custom scrollbar in a visually appealing color to elevate the website's aesthetics. The color #00f2fe suits well with the website's design.

Fixes #1203

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested manually on my local desktop.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Screenshots or example output

Screenshot (485)

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 797d9b7
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6523b7577d0834000995ad19
😎 Deploy Preview https://deploy-preview-1294--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 5, 2023

@letscodedanish is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@letscodedanish letscodedanish deleted the feature/custom-scroll-bar branch October 6, 2023 05:22
@letscodedanish letscodedanish restored the feature/custom-scroll-bar branch October 6, 2023 10:52
@letscodedanish letscodedanish reopened this Oct 6, 2023
@letscodedanish
Copy link
Contributor Author

It fixes the scroll bar

priyankarpal
priyankarpal previously approved these changes Oct 7, 2023
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@atapas
Copy link
Member

atapas commented Oct 9, 2023

Hey @letscodedanish Thanks for the contribution. It looks great. However, here is a small thing you want to take care.

When there are too many items, the scroll handle becomes too small to observe.

image

@letscodedanish
Copy link
Contributor Author

Okay I'll fix that @atapas

@letscodedanish
Copy link
Contributor Author

@atapas scroll handle is fixed now.

@atapas
Copy link
Member

atapas commented Oct 9, 2023

https://deploy-preview-1294--reactplayio.netlify.app/

There is something wrong. UI is not loading. Check the preview URL above.

@letscodedanish
Copy link
Contributor Author

@atapas It's working fine on my system. Have a look.

reactplay-vid.mp4

@atapas
Copy link
Member

atapas commented Oct 10, 2023

https://deploy-preview-1294--reactplayio.netlify.app/

Looks good.. I will close it today.

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@atapas
Copy link
Member

atapas commented Oct 10, 2023

@priyankarpal please provide your review and approval.

@atapas atapas merged commit 0e5a15d into reactplay:main Oct 10, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Improve UX with Custom Scrollbar on Website
3 participants