Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

Fix typo and readme bug #312

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ruelasb
Copy link

@ruelasb ruelasb commented Mar 27, 2017

On line 70 the production server can not find the bundle.js
file because webpack.config.js pushes the bundle.js into the
/public path. The result is a blank page because the
server has not been set up with the proper path of /public.
The Webpack configuration must be applied after the public
directory has been created on line 80 or once the server has
been configured to read from the public directory.

On line 70 the production server can not find the bundle.js
file because webpack.config.js pushes the bundle.js into the
/public path. The result is a blank page because the
server has not been set up with the proper path of /public.
The Webpack configuration must be applied after the public
directory has been created on line 80 or once the server has
been configured to read from the public directory.
@ruelasb
Copy link
Author

ruelasb commented Mar 27, 2017

If it makes it easier to understand I will do some further explanation the changes. Basically when the following instructions are stated in the readme.md file

Now run:
NODE_ENV=production npm start
# For Windows users:
# SET "NODE_ENV=production" && npm start
Congratulations! You now have a production server for this app... 

The server doesn't serve the bundle.js file because at this point we still have not configured the path on the server.js to point to the /public directory.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant