Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with react.dev @ fcd00068 #615

Merged
merged 13 commits into from
Nov 14, 2023
Merged

Sync with react.dev @ fcd00068 #615

merged 13 commits into from
Nov 14, 2023

Conversation

react-translations-bot
Copy link
Collaborator

This PR was automatically generated.

Merge changes from react.dev at fcd0006

The following files have conflicts and may need new translations:

Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.

smikitky and others added 12 commits November 6, 2023 14:09
Summary of changes:
"Server Action", like "Effect", is a React-specific notion
that would be benefited from captailization to be distinguished
from its genertic meaning.

It seems like [Next doc](https://nextjs.org/docs/app/api-reference/functions/server-actions)
has also adopted such connventions and we should probably do the same.

Co-authored-by: xuan.huang <[email protected]>
Summary of changes:
following <reactjs/react.dev#6417>

Co-authored-by: xuan.huang <[email protected]>
Summary of changes:
See <reactjs/react.dev#6417>

Co-authored-by: xuan.huang <[email protected]>
Summary of changes:
See <reactjs/react.dev#6417>.

There is one exception though. The error message
“Rendered fewer hooks than expected” from React is indeed "hooks"
so I kept as-is. Shall we change the error message from React?

Co-authored-by: xuan.huang <[email protected]>
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 78.64 KB (🟡 +19 B) 182.38 KB
/500 78.63 KB (🟡 +19 B) 182.38 KB
/[[...markdownPath]] 80.33 KB (🟡 +19 B) 184.07 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@tdd tdd merged commit 4e78f7f into main Nov 14, 2023
4 checks passed
@tdd tdd deleted the sync-fcd00068 branch November 14, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants