Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support expo-router focus events #2999

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: Support expo-router focus events #2999

wants to merge 2 commits into from

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Apr 8, 2024

Fixes # .

Motivation

Solution

https://docs.expo.dev/router/reference/testing/

We may only need to add tests - it looks like they may unmount - be sure to investigate

Copy link

changeset-bot bot commented Apr 8, 2024

⚠️ No Changeset found

Latest commit: a617a58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ntucker ntucker marked this pull request as draft April 8, 2024 17:06
@ntucker ntucker force-pushed the master branch 3 times, most recently from 55a79fd to 763b401 Compare April 12, 2024 09:52
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.40%. Comparing base (6e9d36b) to head (7d3cd45).
Report is 1 commits behind head on master.

❗ Current head 7d3cd45 differs from pull request most recent head a617a58. Consider uploading reports for the commit a617a58 to get more accurate results

Files Patch % Lines
packages/react/src/hooks/useFocusEffect.native.ts 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2999      +/-   ##
==========================================
- Coverage   98.49%   98.40%   -0.09%     
==========================================
  Files         122      122              
  Lines        2192     2198       +6     
  Branches      448      448              
==========================================
+ Hits         2159     2163       +4     
- Misses         21       23       +2     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ntucker ntucker force-pushed the master branch 5 times, most recently from e715f64 to 8157a3a Compare June 6, 2024 19:13
@ntucker ntucker force-pushed the master branch 2 times, most recently from d9ac06a to 4d8a8a5 Compare June 19, 2024 08:55
@ntucker ntucker force-pushed the master branch 2 times, most recently from 157a636 to 151602e Compare July 1, 2024 20:37
@ntucker ntucker force-pushed the master branch 8 times, most recently from 12eb4e9 to 688c7c6 Compare August 7, 2024 10:14
@ntucker ntucker force-pushed the master branch 5 times, most recently from 186688a to 3b337e7 Compare September 3, 2024 14:05
@ntucker ntucker force-pushed the master branch 3 times, most recently from 9c84326 to 49ac1c4 Compare September 9, 2024 18:54
@ntucker ntucker force-pushed the master branch 3 times, most recently from 26e0e32 to ae882cd Compare September 16, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant