Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sdist #1191

Merged
merged 22 commits into from
Oct 31, 2024
Merged

fix sdist #1191

merged 22 commits into from
Oct 31, 2024

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented Feb 4, 2024

By submitting this pull request you agree that all contributions to this project are made under the MIT license.

Issues

Closes: #1180
Closes: #1183

Solution

Create a link to the JS directory inside src/py/reactpy and include the JS dir as an sdist-only artifact

Checklist

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.

@rmorshea
Copy link
Collaborator Author

rmorshea commented Feb 11, 2024

@Archmonger I'm having some trouble with this on Windows, do you think you can try this branch out and see what's happening. In the meantime I'm gonna purchase a Windows license and install it on an old laptop so I can test this stuff myself going forward.

Never mind. Got past the windows issue.

@shawncrawley
Copy link
Contributor

We're at the final stretch of releasing a new version of our software (Tethys Platform) that introduces reactpy (see this PR). Because our project is deeply rooted in the conda world, the last item that remains is getting reactpy, reactpy-router and reactpy-django added to the conda-forge channel (essentially addressing discussion #850).

I already submitted a PR to the conda-forge/staged-recipes repo, but the automated build checks are failing due to this same sdist issue. So this is my current roadblock. I'm highly motivated to help move things along, but unfortunately I'm fairly novice in many of the underlying technologies/infrastructure used by this project (e.g. Hatch, Invoke, NodeJS, NPM). I'm slowly trying to get up to speed to be more helpful, and will continue to see if there's anything I can tackle myself here. Thanks for everything you've stepped in to do for me in the meantime.

@Archmonger
Copy link
Contributor

I will take a stab at finalizing this PR soon.

There's honestly a lot I want to do to "streamline" the CI in core, but I'll need to do that in a future PR.

@Archmonger
Copy link
Contributor

I'm going to count this as "good enough".

Functionally works, but is fairly janky. As mentioned in my previous post, I'll need to overhaul all of core's CI in a future PR to get rid of the jank.

@Archmonger Archmonger merged commit 0facdca into reactive-python:main Oct 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotADirectoryError when installing from source distribution
3 participants