feat(toolbar): add onOutsideClick prop #391
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an optional
onOutsideClick
callback prop to theToolbar
component.From a UX perspective, "toolbars" should close by default on an outside click. Similar to how dropdowns are handled. Since the component itself does not handle visibility, we can add a prop for the consumer to make it easier to implement this behavior.
e.g
Thank you for the awesome library!