Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolbar): add onOutsideClick prop #391

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

williamgrosset
Copy link

Overview

This PR adds an optional onOutsideClick callback prop to the Toolbar component.

From a UX perspective, "toolbars" should close by default on an outside click. Similar to how dropdowns are handled. Since the component itself does not handle visibility, we can add a prop for the consumer to make it easier to implement this behavior.

e.g

<Toolbar onOutsideClick={() => setOpen(false)}>
  ...
</Toolbar>

Kapture 2024-01-14 at 13 34 01

Kapture 2024-01-14 at 13 43 26

  • Tested locally
  • Added tests
  • Backwards compatible (opt-in)

Thank you for the awesome library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant