Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix older versions of react native changelog URLs #389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ItaloFalzoni
Copy link

@ItaloFalzoni ItaloFalzoni commented Oct 1, 2024

Summary

The previous React Native changelog files have been changed to another file. For example, the version 0.68 of react native has been changed to this link: https://github.com/facebook/react-native/blob/main/CHANGELOG-pre-070.md#v0680, before we were use this link: https://github.com/facebook/react-native/blob/main/CHANGELOG.md#v068 and it was not working very well.

Basically I added an extra function that checks versions prior to 0.70 and invokes a new function that is responsible for assembling the changelog URLs.

Test Plan

yarn start

What are the steps to reproduce?

You can see it live and check the link on the "Useful content for upgrading" section

Checklist

  • I tested this thoroughly
  • I added the documentation in README.md (if needed)

@JVGS1111
Copy link

JVGS1111 commented Oct 7, 2024

Can you guys check this?

@kelset
Copy link
Member

kelset commented Oct 10, 2024

@ItaloFalzoni can you verify that TS checks green locally? on CI it errors with Cannot set property mark of #<Object> which has only a getter (plus there's also an eslint error)

@ItaloFalzoni
Copy link
Author

@kelset

Sorry. I coded on Github Codespace and I didn't see how the TS check works. As soon as possible I will look again to make the review easier. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants