remove SafeAreaView which has no effect on the UI #85
+2
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[GENERAL][REMOVED] - Removed SafeAreaView usage in template app
Test Plan:
Manually editing generated template app.
iOS with SafeAreaView:
ios_with_safeareaview.mp4
iOS without SafeAreaView:
ios_without_safeareaview.mp4
They look the same with or without the SafeAreaView.
Note: It was not handled in the PR but leaving a note as future reference. Safe area seems to be handled in
ScrollView
withcontentInsetAdjustmentBehavior="automatic"
prop (code here). Removing this on iOS looks like this:ios_without_contentInsetAdjustmentBehavior_automatic.mp4