Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build with ndk r27b on top of webkitgtk 2.26.4 #184

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Kudo
Copy link
Member

@Kudo Kudo commented Nov 16, 2024

Why

to support android 16k page sizes and react-native 0.77

How

  • migrate webkit repo from svn to git
  • update to webkitgtk 2.26.4 (previous we had 2.26.1). the main reason is that git repo don't have 2.26.1 tag but 2.26 branch.
  • change the version scheme. originally we use svn revision, but webkit team don't have revision anymore. the new version scheme will base on webkitgtk version.
    $ echo "2.26.4" | awk -F. '{printf "%d%03d%03d\n", $1, $2, $3}'
    2026004
  • update ci, lib builder, and test projects
  • use ndk r27b
  • bump minSdkVersion to 24
  • add -Wl,-z,max-page-size=16384 linker flags

Test Plan

ci passed

- use ndk r27
- use jdk 17
- use android emulator api 24
- use ubuntu-runner and maestro to run e2e test
- gradle wrapper 8.10.2
- agp 8.7.2
- git rm -rf test
- yarn create expo-app -t blank@@sdk-52 test
- add postinstall to package.json to replace jsc dist
- update app.json
  - add appId
  - add jsEngine=jsc
- add maestro.yaml
- migrate repo from svn to git
- since we bump ndk to r27, then we can remove deprecated NDK patches
- set minSdkVersion to 24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant