Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-native-libraries.json #1384

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ravir-simform
Copy link
Contributor

📝 Why & how

It does add few new libraries named below:

  • react-native-audio-waveform
  • react-native-infinite-wheel-picker
  • react-native-graph-kit
  • react-native-sticky-table
  • react-native-tree-selection
  • react-native-photos-gallery
  • react-native-images-preview
  • react-native-radial-slider
  • react-native-country-code-select
  • react-native-animation-catalog
  • react-native-skia-catalog
  • react-native-spinner-button

✅ Checklist

  • Added library to react-native-libraries.json

Copy link
Member

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ravir-simform, thank you so much for adding a batch of missing libraries! 👍

Few things before we can merge:

  • let's remove the false value, they are redundant
  • let's remove README files link from examples, entry name will link to package repository anyway, and we expect apps or snacks in there
  • make sure you have formatted the JSON file via yarn libraries:cleanup command (of pre-commit git hooks)

Those suggestions and few more tips/details can be found in the entry structure description:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants