Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: react-native-nitro-totp #1297

Closed
wants to merge 0 commits into from
Closed

chore: react-native-nitro-totp #1297

wants to merge 0 commits into from

Conversation

4cc3ssX
Copy link

@4cc3ssX 4cc3ssX commented Sep 30, 2024

📝 Why & how

Added react-native-nitro-totp module and updated unmaintained, alternatives field to react-native-totp-utils.

✅ Checklist

  • Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json

Simek
Simek reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @4cc3ssX, thanks for the updates, and adding new entry to the directory! 👌

Just have one question, about the new architecture status for the deprecated package.

react-native-libraries.json Outdated
@@ -9647,7 +9647,10 @@
"githubUrl": "https://github.com/4cc3ssX/react-native-totp-utils",
"examples": ["https://github.com/4cc3ssX/react-native-totp-utils/tree/main/example"],
"ios": true,
"android": true
"android": true,
"newArchitecture": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"newArchitecture": true,
"newArchitecture": true,

Is this correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's correct. Compatible with both new and old architectures while alternative one only supports new architecture.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming! Let's rebase the PR so we can ship it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've to pull to resolve conflicts and discarded my changes. Creating new PR for now.

@4cc3ssX 4cc3ssX closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simek Simek Simek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4cc3ssX @Simek @brentvatne