Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-native-libraries.json #1263

Closed
wants to merge 10 commits into from

Conversation

gabriel-logan
Copy link
Contributor

@gabriel-logan gabriel-logan commented Sep 9, 2024

📝 Why & how

Adds multi form validation library with multiple validation options. This library validates forms in an easy, efficient and secure way.

Add translation library, it offers to translate JSON files, using a private api key from azure api.

Add JavaScript functions to generate valid Brazilian CPF (Cadastro de Pessoas Físicas) and CNPJ (Cadastro Nacional da Pessoa Jurídica) numbers.

Adds integration library with redux in react native and expo, it works by saving the redux state in your preferred storage. Project is written in TypeScript. However, you can use it in JavaScript projects as well.

✅ Checklist

  • [ X] Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json
  • Documented in this PR how to use the feature or replicate the bug.
  • Documented in this PR how you fixed or created the feature.

Copy link
Contributor Author

@gabriel-logan gabriel-logan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package name extracted from 'package.json' at given GitHub repository URL differs with package name in the directory data!

  • Supplied package name: cpf_and_cnpj-generator
  • Extracted package name: Gerador-CPF-e-CNPJ-valido

Regarding this error, the repository name is different from npm itself, is there a problem with that?

The information is correct.

react-native-libraries.json Outdated Show resolved Hide resolved
@Simek
Copy link
Member

Simek commented Sep 9, 2024

Looks like you have removed the entries added in previous PR when resolving conflicts, let's make sure those entries are reverted back (it might be easier to recreate this PR from scratch, based on the up-to-date main).

@gabriel-logan
Copy link
Contributor Author

Package name extracted from 'package.json' at given GitHub repository URL differs with package name in the directory data!

Supplied package name: cpf_and_cnpj-generator
Extracted package name: Gerador-CPF-e-CNPJ-valido
Regarding this error, the repository name is different from npm itself, is there a problem with that?

The information is correct.

If it is a problem I can remove a specific lib

"newArchitecture": true
},
{
"githubUrl": "https://github.com/gabriel-logan/Gerador-CPF-e-CNPJ-valido",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"githubUrl": "https://github.com/gabriel-logan/Gerador-CPF-e-CNPJ-valido",
"githubUrl": "https://github.com/gabriel-logan/Gerador-CPF-e-CNPJ-valido/tree/main/packages/typescript",

If package is in the monorepo, you need to link to a exact folder where wanted package.json resides.

Comment on lines +11827 to +11845
"githubUrl": "https://github.com/Multiform-Validator/typescript-javascript",
"npmPkg": "multiform-validator",
"examples": [
"https://github.com/gabriel-logan/mobile-native-barcode-generator/tree/main/example",
"https://github.com/gabriel-logan/mobile-native-barcode-generator/tree/main/docs"
"https://multiformvalidator.netlify.app/documentation/js"
],
"images": ["https://raw.githubusercontent.com/gabriel-logan/mobile-native-barcode-generator/main/docs/assets/example2.png"],
"android": true
"images": ["https://raw.githubusercontent.com/Multiform-Validator/docs/main/src/app/opengraph-image.png"],
"ios": true,
"android": true,
"web": true,
"expoGo": true,
"newArchitecture": true
},
{
"githubUrl": "https://github.com/gabriel-logan/expo-barcode",
"npmPkg": "expo-barcode",
"githubUrl": "https://github.com/gabriel-logan/Azure-translator-code",
"npmPkg": "azure-translator-code",
"examples": [
"https://github.com/gabriel-logan/expo-barcode/tree/main/example"
"https://azuretranslatorcode.vercel.app/"
],
"android": true
"ios": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still removing the packages added in earlier PR from today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need do something ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, you need to rebase the PR and resolve conflicts, but at this point it might be easier, just to re-create the changeset as a new PR which we can merge in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@gabriel-logan gabriel-logan closed this by deleting the head repository Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants