feat: separate package for PackageManager util #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for working on this! In my opinion, in this PR we should focus only on extracting currently existing logic into separate package. IIRC pnpm still requires some tweaks to make it work with CLI, (check here) so to not block things, I'd remove pnpm part from this PR
szymonrybczak
approved these changes
Aug 22, 2024
|
@arpitBhalla can you take a look at failing tests? 🙏 |
szymonrybczak
force-pushed
the
feat/package-manager
branch
from
a092ed0
to
d047334
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Related rise-tools/rise-tools#161
Test Plan:
Checklist
^ @grabbou