Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added check prop 'visible' on undefined #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added check prop 'visible' on undefined #111

wants to merge 2 commits into from

Conversation

devdammit
Copy link

@devdammit devdammit commented Dec 25, 2017 •
edited by yoyo837
Loading

close #95

@yesmeck
Copy link
Member

yesmeck commented Dec 26, 2017

@devdammit Thanks, could you write a test?

@yesmeck yesmeck self-requested a review December 26, 2017 13:21
@devdammit
Copy link
Author

@yesmeck, sure. :)

@devdammit
Copy link
Author

@yesmeck, I close the PR or something needs to be done? :)

@evanhli
Copy link

evanhli commented Oct 15, 2018

Hey can this get merged in? Im building a feature that relies on visible to be undefined @yesmeck

@FlorisVeldhuizen
Copy link

Hi, can this be approved :)?

@yoyo837
Copy link
Member

yoyo837 commented Feb 3, 2023

Rebase please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesmeck yesmeck Awaiting requested review from yesmeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Determining the availability of props.visible
5 participants
@devdammit @yesmeck @evanhli @FlorisVeldhuizen @yoyo837