feat: remove *-show-arrow cls when showArrow is true (#433)

* feat: remove *-show-arrow cls when showArrow is true * feat: update test case
react-component · Jan 18, 2023 · 2b86fce · 2b86fce
1 parent bf78c2e
commit 2b86fce
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/src/Tooltip.tsx b/src/Tooltip.tsx
@@ -5,7 +5,6 @@ import type { TriggerProps } from 'rc-trigger';
 import type { AlignType, AnimationType, ActionType } from 'rc-trigger/lib/interface';
 import { placements } from './placements';
 import Popup from './Popup';
-import classNames from 'classnames';
 
 export interface TooltipProps extends Pick<TriggerProps, 'onPopupAlign' | 'builtinPlacements'> {
   trigger?: ActionType | ActionType[];
@@ -102,9 +101,7 @@ const Tooltip = (props: TooltipProps, ref) => {
 
   return (
     <Trigger
-      popupClassName={classNames(overlayClassName, {
-        [`${prefixCls}-show-arrow`]: showArrow,
-      })}
+      popupClassName={overlayClassName}
       prefixCls={prefixCls}
       popup={getPopupElement}
       action={trigger}

diff --git a/tests/index.test.tsx b/tests/index.test.tsx
@@ -174,7 +174,6 @@ describe('rc-tooltip', () => {
         </Tooltip>,
       );
       fireEvent.click(container.querySelector('.target'));
-      expect(container.querySelector('.rc-tooltip').classList).toContain('rc-tooltip-show-arrow');
       expect(container.querySelector('.rc-tooltip-content').outerHTML).toBe(
         '<div class="rc-tooltip-content"><div class="rc-tooltip-arrow"></div><div class="rc-tooltip-inner" role="tooltip"><strong class="x-content">Tooltip content</strong></div></div>',
       );
@@ -192,7 +191,6 @@ describe('rc-tooltip', () => {
         </Tooltip>,
       );
       fireEvent.click(container.querySelector('.target'));
-      expect(container.querySelector('.rc-tooltip').classList).toContain('rc-tooltip-show-arrow');
       expect(container.querySelector('.rc-tooltip-content').outerHTML).toBe(
         '<div class="rc-tooltip-content"><div class="rc-tooltip-arrow"></div><div class="rc-tooltip-inner" role="tooltip"><strong class="x-content">Tooltip content</strong></div></div>',
       );