Allow easier styling of mark and dot #949
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the other components we have like `tracks`, `rail` and `handle`, this allows easier styling via classes or inline styles. I've also separated the active styles of both, as being able to style, how a selected range should look is very helpful.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This might also allow to drop |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #949 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 13 13
Lines 551 554 +3
Branches 151 154 +3
=======================================
+ Hits 550 553 +3
Misses 1 1 ☔ View full report in Codecov by Sentry. |
lvnam96
suggested changes
Feb 19, 2024
Comment on lines
+38
to
+39
| ...(active ? styles.markActive : {}), | ||
| ...styles.mark, |
There was a problem hiding this comment.
This should be:
...styles.mark,
...(active ? styles.markActive : {}),markActive styles should override the default mark styles, not the other way around.
Comment on lines
+5
to
+9
| export type OnStartMove = ( | ||
| e: React.MouseEvent | React.TouchEvent, | ||
| valueIndex: number, | ||
| startValues?: number[], | ||
| ) => void; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the other components we have like
tracks,railandhandle, this allows easier styling via classes or inline styles.I've also separated the active styles of both, as being able to style, how a selected range should look is very helpful.