Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolves an issue that occurs when showTime and changeOnBlur exist at the same time #676

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

Yuiai01
Copy link
Contributor

@Yuiai01 Yuiai01 commented Sep 18, 2023

发现两个问题:
1、之前当 showTime 和 changeOnBlur 同时存在时,会先执行 changeOnBlur 对应的事件,但是因为取值逻辑的关系无法获取到正确的 value,导致不会触发后续的 onCalendarChange;
2、showTime 和 changeOnBlur 同时存在时,当切换输入框就会关闭时间选择面板。

ref: ant-design/ant-design#44280

@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 3:45pm

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #676 (7faa6f6) into master (8f802d2) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 7faa6f6 differs from pull request most recent head 56a7fc5. Consider uploading reports for the commit 56a7fc5 to get more accurate results

@@           Coverage Diff           @@
##           master     #676   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          56       56           
  Lines        2443     2443           
  Branches      741      734    -7     
=======================================
  Hits         2417     2417           
  Misses         24       24           
  Partials        2        2           
Files Changed Coverage Δ
src/Picker.tsx 100.00% <ø> (ø)
src/RangePicker.tsx 99.29% <100.00%> (ø)
src/hooks/usePickerInput.ts 98.71% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit 01a9c98 into react-component:master Sep 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants