Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: picker locale trigger #668

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix: picker locale trigger #668

merged 1 commit into from
Aug 23, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 23, 2023

resolve ant-design/ant-design#44337

rc-picker 本身其实无法感知日期库的变化,但是我们可以利用 locale 做一下对比。如果 locale prop 变了,那么就假定对应的日期库语言也变了。

@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 6:38am

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #668 (f1b0ce2) into master (6919d7e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f1b0ce2 differs from pull request most recent head ac37ce6. Consider uploading reports for the commit ac37ce6 to get more accurate results

@@           Coverage Diff           @@
##           master     #668   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          56       56           
  Lines        2430     2431    +1     
  Branches      734      735    +1     
=======================================
+ Hits         2407     2408    +1     
  Misses         21       21           
  Partials        2        2           
Files Changed Coverage Δ
src/hooks/useValueTexts.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit e5c30f5 into master Aug 23, 2023
8 checks passed
@zombieJ zombieJ deleted the fix-locale branch August 23, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigProvider locale 变化时 DatePicker 显示内容不会同时变化
1 participant