feat: support customize clear icon #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kiner-tang
commented
Jul 25, 2023
kiner-tang
commented
- 📝 [RFC] Unify allowClear api for clearable component ant-design/ant-design#43582
- Allow Custom Clear Icon for DatePicker, Input.Password and TreeSelect ant-design/ant-design#43495
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
=======================================
Coverage 99.04% 99.05%
=======================================
Files 55 56 +1
Lines 2416 2426 +10
Branches 716 720 +4
=======================================
+ Hits 2393 2403 +10
Misses 21 21
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MadCcc
reviewed
Jul 25, 2023
src/hooks/useAllowClear.tsx
Outdated
Comment on lines
54
to
55
| e.preventDefault(); | ||
| e.stopPropagation(); |
There was a problem hiding this comment.
这是现有逻辑，去掉后不知道会不会导致一些不可意料的问题
MadCcc
reviewed
Jul 25, 2023
src/hooks/useAllowClear.tsx
Outdated
| clearIcon: ( | ||
| <span | ||
| onMouseDown={(e) => { | ||
| e.preventDefault(); |
There was a problem hiding this comment.
preventDefault 有用么？有可能导致用户自定义的 icon 事件失效
There was a problem hiding this comment.
这是现有逻辑，去掉后不知道会不会导致一些不可意料的问题
zombieJ
reviewed
Jul 25, 2023
zombieJ
reviewed
Jul 25, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
zombieJ
reviewed
Jul 25, 2023
zombieJ
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.