Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shows current week as selected in correct year #313

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

NgChiKin
Copy link
Contributor

@NgChiKin NgChiKin commented Nov 4, 2021

@vercel
Copy link

vercel bot commented Nov 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/picker/4Rhg1BHcELtwyxARA8hPCZHKwciq
✅ Preview: https://picker-git-fork-ngchikin-datepicker-week-32ecf1-react-component.vercel.app

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #313 (eafd593) into master (c377ca0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head eafd593 differs from pull request most recent head 377cf69. Consider uploading reports for the commit 377cf69 to get more accurate results

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          55       55           
  Lines        2416     2418    +2     
  Branches      716      718    +2     
=======================================
+ Hits         2393     2395    +2     
  Misses         21       21           
  Partials        2        2           
Files Changed Coverage Δ
src/utils/dateUtil.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@afc163 afc163 requested a review from zombieJ November 4, 2021 03:17
@bencerf
Copy link

bencerf commented Aug 24, 2022

Interested for this fix, thanks @NgChiKin for the PR +1

@afc163
Copy link
Member

afc163 commented Aug 25, 2022

Could you add a test case?

@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 9:22am

@zombieJ zombieJ merged commit ec9c4ad into react-component:master Jul 25, 2023
8 checks passed
@zombieJ
Copy link
Member

zombieJ commented Jul 25, 2023

+ [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker Week selector shows current week as selected in every year
5 participants