Skip to content

Commit

Permalink
fix rest of typos
Browse files Browse the repository at this point in the history
  • Loading branch information
jbat committed Apr 30, 2024
1 parent 3b99901 commit af1f2a8
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/superset/dashboard/bulk_delete.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def initialize(dashboard_ids: [])

def perform
raise InvalidParameterError, "dashboard_ids array of integers expected" unless dashboard_ids.is_a?(Array)
raise InvalidParameterError, "dashboard_ids array must contin Integer only values" unless dashboard_ids.all? { |item| item.is_a?(Integer) }
raise InvalidParameterError, "dashboard_ids array must contain Integer only values" unless dashboard_ids.all? { |item| item.is_a?(Integer) }

logger.info("Attempting to delete dashboards with id: #{dashboard_ids.join(', ')}")
response
Expand Down
2 changes: 1 addition & 1 deletion lib/superset/dashboard/list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def list_attributes
def validate_constructor_args
raise InvalidParameterError, "title_contains must be a String type" unless title_contains.is_a?(String)
raise InvalidParameterError, "tags_equal must be an Array type" unless tags_equal.is_a?(Array)
raise InvalidParameterError, "tags_equal array must contin string only values" unless tags_equal.all? { |item| item.is_a?(String) }
raise InvalidParameterError, "tags_equal array must contain string only values" unless tags_equal.all? { |item| item.is_a?(String) }
raise InvalidParameterError, "ids_not_in must be an Array type" unless ids_not_in.is_a?(Array)
end
end
Expand Down
2 changes: 1 addition & 1 deletion lib/superset/dataset/bulk_delete.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def initialize(dataset_ids: [])

def perform
raise InvalidParameterError, "dataset_ids array of integers expected" unless dataset_ids.is_a?(Array)
raise InvalidParameterError, "dataset_ids array must contin Integer only values" unless dataset_ids.all? { |item| item.is_a?(Integer) }
raise InvalidParameterError, "dataset_ids array must contain Integer only values" unless dataset_ids.all? { |item| item.is_a?(Integer) }

logger.info("Attempting to delete datasets with id: #{dataset_ids.join(', ')}")
response
Expand Down
2 changes: 1 addition & 1 deletion lib/superset/tag/add_to_object.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def validate_constructor_args
raise InvalidParameterError, "object_type_id is not a known value" unless ObjectType.list.include?(object_type_id)
raise InvalidParameterError, "object_id integer is required" unless object_id.present? && object_id.is_a?(Integer)
raise InvalidParameterError, "tags array is required" unless tags.present? && tags.is_a?(Array)
raise InvalidParameterError, "tags array must contin string only values" unless tags.all? { |item| item.is_a?(String) }
raise InvalidParameterError, "tags array must contain string only values" unless tags.all? { |item| item.is_a?(String) }
end

private
Expand Down
2 changes: 1 addition & 1 deletion spec/superset/dashboard/bulk_delete_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
let(:dashboard_ids) { [1, 'string'] }

it 'raises an error' do
expect { subject.perform }.to raise_error(Superset::Request::InvalidParameterError, "dashboard_ids array must contin Integer only values")
expect { subject.perform }.to raise_error(Superset::Request::InvalidParameterError, "dashboard_ids array must contain Integer only values")
end
end

Expand Down
2 changes: 1 addition & 1 deletion spec/superset/dataset/bulk_delete_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
let(:dataset_ids) { [1, 'string'] }

it 'raises an error' do
expect { subject.perform }.to raise_error(Superset::Request::InvalidParameterError, "dataset_ids array must contin Integer only values")
expect { subject.perform }.to raise_error(Superset::Request::InvalidParameterError, "dataset_ids array must contain Integer only values")
end
end

Expand Down
2 changes: 1 addition & 1 deletion spec/superset/tag/add_to_object_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
let(:tags) { [1, 2] }

it 'raises an error' do
expect { subject.perform }.to raise_error(Superset::Request::InvalidParameterError, "tags array must contin string only values")
expect { subject.perform }.to raise_error(Superset::Request::InvalidParameterError, "tags array must contain string only values")
end
end
end
Expand Down

0 comments on commit af1f2a8

Please sign in to comment.