chore: Publish pr-feature-command-intents

rdkcentral · May 21, 2024 · cd8ae26 · cd8ae26
1 parent 85a8598
commit cd8ae26
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 19 deletions.
diff --git a/requirements/pr-feature-command-intents/specifications/firebolt-open-rpc.json b/requirements/pr-feature-command-intents/specifications/firebolt-open-rpc.json
@@ -20124,6 +20124,11 @@
 							"action": {
 								"const": "home"
 							}
+						},
+						"not": {
+							"required": [
+								"data"
+							]
 						}
 					}
 				],
@@ -20152,6 +20157,11 @@
 							"action": {
 								"const": "launch"
 							}
+						},
+						"not": {
+							"required": [
+								"data"
+							]
 						}
 					}
 				],
@@ -20340,7 +20350,10 @@
 								},
 								"additionalProperties": false
 							}
-						}
+						},
+						"required": [
+							"data"
+						]
 					}
 				],
 				"examples": [
@@ -20498,6 +20511,7 @@
 									"type": "object",
 									"properties": {
 										"options": {
+											"type": "object",
 											"maxProperties": 1
 										}
 									}
@@ -20506,6 +20520,7 @@
 									"type": "object",
 									"properties": {
 										"options": {
+											"type": "object",
 											"maxProperties": 0
 										}
 									}

diff --git a/requirements/pr-feature-command-intents/specifications/firebolt-specification.json b/requirements/pr-feature-command-intents/specifications/firebolt-specification.json
@@ -21034,6 +21034,11 @@
 									"action": {
 										"const": "home"
 									}
+								},
+								"not": {
+									"required": [
+										"data"
+									]
 								}
 							}
 						],
@@ -21062,6 +21067,11 @@
 									"action": {
 										"const": "launch"
 									}
+								},
+								"not": {
+									"required": [
+										"data"
+									]
 								}
 							}
 						],
@@ -21250,7 +21260,10 @@
 										},
 										"additionalProperties": false
 									}
-								}
+								},
+								"required": [
+									"data"
+								]
 							}
 						],
 						"examples": [
@@ -21408,6 +21421,7 @@
 											"type": "object",
 											"properties": {
 												"options": {
+													"type": "object",
 													"maxProperties": 1
 												}
 											}
@@ -21416,6 +21430,7 @@
 											"type": "object",
 											"properties": {
 												"options": {
+													"type": "object",
 													"maxProperties": 0
 												}
 											}

diff --git a/.../pr-feature-command-intents/specifications/intents/command-and-control/index.md b/.../pr-feature-command-intents/specifications/intents/command-and-control/index.md
@@ -342,7 +342,7 @@ currently paused media should resume.
 If the action is play, and there is something playbable selected, then
 playback of the selected asset should be initiated.
 
-If the action is replay, then the currently paused media should restart
+If the action is replay, then the currently paused or playing media should restart
 from the beginning. This should work even if the decoder has finished,
 and its resources have been released.
 
@@ -432,8 +432,6 @@ These intents allow users to fast-forward or rewind:
 }
 ```
 
-TODO: send closed captions vs subtitles 
-
 Speed is a float in the range of 0 (non-includsive) to 10 (inclusive),
 with values between 0 and 1 denoting slow motion.
 
@@ -475,7 +473,6 @@ This intent allows a user to turn closed captions on or off.
         }
     }
 }
-
 ```
 
 Additionally, this intent may specify a toggle:
@@ -597,8 +594,6 @@ When providing a `speed` this intent **MAY** also set the `relative` property to
 }
 ```
 
-The voice guidance intent **MUST** have only one property, `speed`, `toggle`, `value` and **MUST NOT** comebine them in a single intent.
-
 Finally, the intent **MAY** specify a `verbosity` property, which **MUST** use one of the following values is provided:
 
 | Value  | Description |
@@ -829,7 +824,9 @@ Setting the scale to `1` turns off magnification. Setting the scale to a value g
 
 Even if a Firebolt platform does not support specifying the numeric scale, it **MUST** turn magnifacation on and off based on them.
 
-The magnification intent **MUST** have only one property, `scale`, `toggle`, `value` and **MUST NOT** comebine them in a single intent.
+If the intent has the `toggle` property, then it **MUST NOT** have the `scale` or `value` property.
+
+If the intent has the `value` property, then it **MUST NOT** have the `toggle`.
 
 ### 3.6. Interaction Intents
 
@@ -876,11 +873,6 @@ The select intent allows users to tell an app select, e.g.,
 whatever is focused. This is a platform-level intent that effectively
 sends the "Ok" or "Select" key to the current app.
 
-**NOTE**: i don\'t like using "click" here, but i can\'t think of a
-good word that isn\'t super vague. "Select" means highlighting, not
-actually hitting okay, so we can\'t use that. I considered "activate"
-but that seems odd\... Open to discussing this.
-
 ```json
 {
     "type": "xrn:firebolt:intent:platform:interaction",
@@ -917,19 +909,16 @@ up/down/left/right:
         "action": "scroll",
         "data": {
             "direction": "up" | "down" | "left" | "right",
-            "unit": "page" | "line" | "percent",
-            "distance": 2.5
+            "unit": "page" | "line" | "percent"
         },
         "context": {
             "source": "voice"
         }
     }
 }
-
 ```
 
-The distance is a float that represents how many of units to scroll. All
-three data properties are required.
+Both `direction` and `unit` are required.
 
 These Intents will generate appropriate browser / DOM scrolling
 operations that don\'t require custom APIs.