Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Addressed architectural review comments #316

Merged
merged 4 commits into from
Sep 18, 2024
Merged

fix: Addressed architectural review comments #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
148416c
fix: Addressed review comments
kevinshahfws Sep 17, 2024
4f8d746
Merge branch 'next' of https://github.com/rdkcentral/firebolt-apis in…
kevinshahfws Sep 17, 2024
f2ccc8f
fix: latest next
kevinshahfws Sep 17, 2024
76159a6
Merge branch 'next' into review-comments-1-4-0
kevinshahfws Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 13 additions & 10 deletions src/openrpc/device.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
},
{
"name": "platform",
"summary": "Get a transient platform identifier for the device. This API should be used to correlate metrics on the device only and cannot be guaranteed to have consistent responses across platforms.",
"summary": "Get a platform identifier for the device. This API should be used to correlate metrics on the device only and cannot be guaranteed to have consistent responses across platforms.",
"params": [],
"tags": [
{
Expand Down Expand Up @@ -348,15 +348,15 @@
}
],
"result": {
"name": "supportedHdcpVersions",
"summary": "the supported HDCP versions",
"name": "negotiatedHdcpVersions",
"summary": "the negotiated HDCP versions",
"schema": {
"$ref": "#/components/schemas/HDCPVersionMap"
}
},
"examples": [
{
"name": "Getting the supported HDCP versions",
"name": "Getting the negotiated HDCP versions",
"params": [],
"result": {
"name": "Default Result",
Expand All @@ -370,7 +370,7 @@
},
{
"name": "hdr",
"summary": "Get the negotiated HDR formats for the connected display and device",
"summary": "Get the negotiated HDR formats for the connected display and device. \n\n For devices that do not require additional connections (e.g. panels), `true` will be returned for all profiles.",
"params": [],
"tags": [
{
Expand All @@ -384,15 +384,15 @@
}
],
"result": {
"name": "supportedHdrFormats",
"summary": "the supported HDR formats",
"name": "negotiatedHdrFormats",
"summary": "the negotiated HDR formats",
"schema": {
"$ref": "#/components/schemas/HDRFormatMap"
}
},
"examples": [
{
"name": "Getting the supported HDR formats",
"name": "Getting the negotiated HDR formats",
"params": [],
"result": {
"name": "Default Result",
Expand Down Expand Up @@ -457,6 +457,9 @@
"x-uses": [
"xrn:firebolt:capability:device:info"
]
},
{
"name": "deprecated"
}
],
"result": {
Expand Down Expand Up @@ -879,7 +882,7 @@
"dolbyVision",
"hlg"
],
"description": "The type of HDR format that is supported"
"description": "The type of HDR format"
},
"HDCPVersionMap": {
"title": "HDCPVersionMap",
Expand All @@ -896,7 +899,7 @@
"hdcp1.4",
"hdcp2.2"
],
"description": "The type of HDCP versions that is supported"
"description": "The type of HDCP versions"
},
"DeviceVersion": {
"title": "DeviceVersion",
Expand Down
37 changes: 0 additions & 37 deletions src/openrpc/discovery.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1250,43 +1250,6 @@
"name": "success",
"value": true
}
},
{
"name": "Launch the Aggregated Experience to it's search screen.",
"params": [
{
"name": "appId",
"value": "xrn:firebolt:application-type:main"
},
{
"name": "intent",
"value": {
"action": "search",
"data": {
"query": "a cool show",
"suggestions": [
{
"entityType": "program",
"programType": "movie",
"entityId": "xyz"
},
{
"entityType": "music",
"musicType": "song",
"entityId": "abc"
}
]
},
"context": {
"source": "voice"
}
}
}
],
"result": {
"name": "success",
"value": true
}
}
]
},
Expand Down
Loading