Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Spec and Doc fixes for Release 1.4.0 #304

Merged
merged 16 commits into from
Sep 3, 2024
Merged

feat: Spec and Doc fixes for Release 1.4.0 #304

merged 16 commits into from
Sep 3, 2024

Conversation

kevinshahfws
Copy link
Contributor

@kevinshahfws kevinshahfws commented Aug 22, 2024 •
edited
Loading

This PR contains below fixes:

  1. Add an array of suggested entities to the Search Intent
  2. Update device.distributor description
  3. Update device.platform description
  4. Update device.model description
  5. Update device.make description
  6. Update Localization.AdditionalInfo
  7. Update capability for SecondScreen.protocols
  8. Remove extra space from Discovery.launch example

@github-actions GitHub Actions
Copy link

Core SDK - MFOS standalone sanity report:
Passes - 200 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27497755023/artifacts/1844467628
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10515788640

jlacivita
jlacivita requested changes Aug 23, 2024
View reviewed changes
src/schemas/intents.json Outdated Show resolved Hide resolved
src/schemas/intents.json Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Core SDK - MFOS standalone sanity report:
Passes - 200 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27529639507/artifacts/1847697074
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10528215579

kpears201
kpears201 reviewed Aug 23, 2024
View reviewed changes
src/schemas/intents.json Outdated Show resolved Hide resolved
jlacivita
jlacivita previously approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@jlacivita jlacivita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/openrpc/discovery.json
"value": {
"action": "search",
"data": {
"query": "a cool show",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should maybe search for "a cool movie" given the results...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I know I sent you that example :)

@github-actions GitHub Actions
Copy link

Core SDK - MFOS standalone sanity report:
Passes - 200 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27531597164/artifacts/1847916012
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10528899460

kpears201
kpears201 previously approved these changes Aug 23, 2024
View reviewed changes
@kevinshahfws kevinshahfws dismissed stale reviews from kpears201 and jlacivita via 65482b6 August 23, 2024 16:36
@github-actions GitHub Actions
Copy link

Core SDK - MFOS standalone sanity report:
Passes - 200 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27532411851/artifacts/1848005758
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10529186738

jlacivita
jlacivita previously approved these changes Aug 23, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Core SDK - MFOS standalone sanity report:
Passes - 200 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27535292677/artifacts/1848313750
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10530183878

@github-actions GitHub Actions
Copy link

Core SDK - MFOS standalone sanity report:
Passes - 200 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27662543158/artifacts/1860703814
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10582176488

@github-actions GitHub Actions
Copy link

Core SDK - MFOS standalone sanity report:
Passes - 200 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27662778434/artifacts/1860727279
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10582260858

@kevinshahfws kevinshahfws changed the title feat: Included entity array in Search Intent feat: Spec and Doc fixes for Release 1.4.0 Aug 29, 2024
@github-actions GitHub Actions
Copy link

Core SDK - MFOS standalone sanity report:
Passes - 199 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27770148768/artifacts/1871668980
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10621560937

@github-actions GitHub Actions
Copy link

Core SDK - MFOS standalone sanity report:
Passes - 200 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27770601147/artifacts/1871720005
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10621708126

@github-actions GitHub Actions
Copy link

Core SDK - MFOS standalone sanity report:
Passes - 200 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27810856654/artifacts/1875869169
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10637011745

jlacivita
jlacivita previously approved these changes Sep 3, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Core SDK - MFOS standalone sanity report:
Passes - 200 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27930853154/artifacts/1887080091
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10687024332

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Core SDK - MFOS standalone sanity report:
Passes - 200 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27931028919/artifacts/1887098600
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10687085993

@kevinshahfws kevinshahfws merged commit 191664b into next Sep 3, 2024
8 checks passed
kschrief pushed a commit that referenced this pull request Sep 3, 2024
@semantic-release-bot
chore(release): 1.4.0-next.1 [skip ci]
2733814 
# [1.4.0-next.1](v1.3.1-next.3...v1.4.0-next.1) (2024-09-03)

### Features

* Spec and Doc fixes for Release 1.4.0 ([#304](#304)) ([191664b](191664b))
@kschrief
Copy link
Contributor

kschrief commented Sep 3, 2024

🎉 This PR is included in version 1.4.0-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

kschrief pushed a commit that referenced this pull request Sep 23, 2024
@semantic-release-bot
chore(release): 1.4.0 [skip ci]
0270f4c 
# [1.4.0](v1.3.0...v1.4.0) (2024-09-23)

### Bug Fixes

* Added deprecation note in screen resolution method ([#323](#323)) ([e146c43](e146c43))
* Added individual sdk openrpcs to the doc specification ([#311](#311)) ([ace1d64](ace1d64))
* Addressed architectural review comments ([#316](#316)) ([a89275a](a89275a))
* Adjust type in CPP device template due to openrpc change ([#307](#307)) ([1f10a15](1f10a15))
* Bump firebolt-openrpc to fix typescript ([#305](#305)) ([62887cf](62887cf))
* CHANGELOG.md links ([972ab20](972ab20))
* CI fix for file exists ([#308](#308)) ([b44c11a](b44c11a))
* core CHANGELOG.md links ([9987742](9987742))
* Modified device.hdr description ([#319](#319)) ([fd2bfb0](fd2bfb0))
* Reverted App selection tag change ([#322](#322)) ([eee90e4](eee90e4))
* Spec and Doc fixes ([#302](#302)) ([6010a85](6010a85))
* Update to CHANGELOG.md for Release 1.4.0 ([a509cb6](a509cb6))
* Updated the artifact upload version for workflow ([#317](#317)) ([ef9b441](ef9b441))
* Updated xrn:firebolt:capability:secondscreen:protocol to should ([#310](#310)) ([1895fe6](1895fe6))

### Features

* Add global subscribe & HDMI tests to manage test app ([#320](#320)) ([63962ab](63962ab))
* Add OpenRPC to generated C++ SDK ([#314](#314)) ([6ed96cb](6ed96cb))
* Fix Core SDK test app ([#321](#321)) ([3a78534](3a78534))
* Spec and Doc fixes for Release 1.4.0 ([#304](#304)) ([191664b](191664b))
@kschrief
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlacivita jlacivita jlacivita approved these changes

@kpears201 kpears201 kpears201 left review comments

@alkalinecoffee alkalinecoffee Awaiting requested review from alkalinecoffee

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinshahfws @kschrief @jlacivita @kpears201