feat: Add openrpc changes based on the requirements #254
Conversation
| "AudioOutput": { | ||
| "title": "AudioOutput", | ||
| "type": "string", | ||
| "enum": [ |
There was a problem hiding this comment.
Do these values need to be capitalized as per requirements doc?
| "MONO", | ||
| "STEREO", | ||
| "SURROUND", | ||
| "SURROUND_7_1" |
| "MimeType": { | ||
| "type": "string", | ||
| "description": "Enumeration of possible Mimetypes.", | ||
| "enum": [ |
There was a problem hiding this comment.
Do methods returning MIME types need to respond with the internal name (AUDIO_AC3) or value (audio/ac3)? I assume the latter but just checking.
src/openrpc/device.json
Outdated
| }, | ||
| { | ||
| "name": "videoFormatPossible", | ||
| "summary": "Get the possible video formats", |
There was a problem hiding this comment.
This method is a check, it does not return any video formats
src/openrpc/device.json
Outdated
| }, | ||
| { | ||
| "name": "audioFormatPossible", | ||
| "summary": "Check the possible video formats", |
There was a problem hiding this comment.
Summary is for video but this is an audio method
src/openrpc/display.json
Outdated
| "params": [], | ||
| "result": { | ||
| "name": "height", | ||
| "summary": "Height of the display device in centimeters", |
There was a problem hiding this comment.
The name and summary here are incorrect
src/openrpc/display.json
Outdated
| "params": [], | ||
| "result": { | ||
| "name": "resolution", | ||
| "summary": "Height of the display device in centimeters", |
There was a problem hiding this comment.
The summary is incorrect; this returns a resolution
src/openrpc/display.json
Outdated
| }, | ||
| { | ||
| "name": "hdr", | ||
| "summary": "Returns an array of valid HDR profiles that the display supports", |
There was a problem hiding this comment.
Is this summary accurate? Its not just what the display supports, but what's supported given the supplied video resolution (if I'm understanding the requirements correctly).
|
|
alkalinecoffee
force-pushed
the
feature/media-info-updates
branch
from
10fbf15 to
9dd77d2
Compare
|
PR will be merged to the feature branch and work will progress in the main feature branch |
No description provided.