Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Release NPM for PR #207

Merged
merged 38 commits into from
Nov 13, 2023
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
e0db56f
feature: Release NPM for PR
kevinshahfws Nov 6, 2023
5aa843c
feature: Release NPM for PR
kevinshahfws Nov 6, 2023
0803f43
Added branch name in .releaserc
kevinshahfws Nov 6, 2023
4648073
Added branch name in .releaserc
kevinshahfws Nov 6, 2023
66dd0a4
Added branch name in .releaserc
kevinshahfws Nov 6, 2023
a49dfbb
Added branch name in .releaserc
kevinshahfws Nov 6, 2023
c902f2e
Added branch name in .releaserc
kevinshahfws Nov 6, 2023
e9bdd7d
Removed pr-channel reference
kevinshahfws Nov 6, 2023
95e65a0
Removed pr-channel reference
kevinshahfws Nov 6, 2023
007209f
npm version command
kevinshahfws Nov 10, 2023
10e60dd
npm version command
kevinshahfws Nov 10, 2023
df674ef
npm version command
kevinshahfws Nov 10, 2023
35d8543
npm version command
kevinshahfws Nov 10, 2023
e039134
npm version command
kevinshahfws Nov 10, 2023
1fd99b5
Updated if condition for release npm
kevinshahfws Nov 10, 2023
64a79df
Updated if condition for build artifact
kevinshahfws Nov 10, 2023
1508ff2
Updated channel name to replace with -
kevinshahfws Nov 10, 2023
8db8fec
Updated channel name to replace with -
kevinshahfws Nov 10, 2023
d475606
Updated release name for PR
kevinshahfws Nov 10, 2023
ec65124
Debug for prerelease
kevinshahfws Nov 10, 2023
59e82f6
PR deploy
kpears201 Nov 10, 2023
e8cee5a
PR deploy
kpears201 Nov 10, 2023
d449196
PR deploy
kpears201 Nov 10, 2023
1737f38
PR deploy
kpears201 Nov 10, 2023
e630716
PR deploy
kpears201 Nov 10, 2023
442b9e3
PR deploy
kpears201 Nov 10, 2023
1da0c00
PR deploy
kpears201 Nov 10, 2023
dd46914
PR deploy
kpears201 Nov 10, 2023
9d4ad3a
PR deploy
kpears201 Nov 10, 2023
917d5c5
PR deploy
kpears201 Nov 10, 2023
d7e0b68
PR deploy
kpears201 Nov 10, 2023
b37342d
PR deploy
kpears201 Nov 10, 2023
f0d954b
PR deploy
kpears201 Nov 10, 2023
261c28b
PR deploy
kpears201 Nov 10, 2023
678102e
PR deploy
kpears201 Nov 10, 2023
d5072e6
PR deploy
kpears201 Nov 10, 2023
fc478c0
PR deploy
kpears201 Nov 10, 2023
4e93b24
PR deploy
kpears201 Nov 13, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/release-github.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ on:
branches:
- 'next'
- 'proposed'

env:
HUSKY: 0
jobs:
Expand Down Expand Up @@ -69,18 +70,25 @@ jobs:
run: npx semantic-release --dry-run
- name: Build artifacts for PRs
if: github.event_name == 'pull_request'
run: npm run dist
run: |
npm version prerelease --preid pr207 --workspaces --git-tag-version false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need this twice now, --include-workspace-root fixes that

npm version prerelease --preid pr207 --workspaces --include-workspace-root --git-tag-version false
npm run dist
- name: Check if semantic-release created a build
id: check_build
uses: andstor/file-existence-action@v2
with:
files: "./src/sdks/core/dist/lib/firebolt.mjs"
- name: Release Firebolt SDKs to NPM
if: steps.check_build.outputs.files_exists == 'true' && github.event_name != 'pull_request' && (github.ref_name != 'main' || github.event_name == 'workflow_dispatch')
#if: steps.check_build.outputs.files_exists == 'true' && github.event_name != 'pull_request' && (github.ref_name != 'main' || github.event_name == 'workflow_dispatch')
if: steps.check_build.outputs.files_exists == 'true' && (github.ref_name != 'main' || github.event_name == 'workflow_dispatch')
env:
NPM_TOKEN: ${{ secrets.SEMANTIC_RELEASE_NPM_TOKEN }} # <-- Allows semantic-release to publish to npm without 2 factor auth.
npm_config_tag: ${{ env.NPM_DIST_TAG }} # <-- For main, this is `latest.` Otherwise, `next`, `next-major`, etc. See ./.releaserc for release branch config.
run: npm publish --tag $RELEASE_CHANNEL --workspaces
run: |
echo "NPM DIST TAG ::: " ${{ env.NPM_DIST_TAG }}
echo "Release Channel ::: " $RELEASE_CHANNEL
npm publish --tag $RELEASE_CHANNEL --workspaces
- name: Dry-run Firebolt SDKs to NPM
if: steps.check_build.outputs.files_exists == 'true' && (github.ref_name == 'main' && github.event_name != 'workflow_dispatch')
env:
Expand All @@ -96,7 +104,7 @@ jobs:
cd /tmp
git clone https://rdkcentral:[email protected]/rdkcentral/firebolt.git ./firebolt-docs
- name: Release docs to GitHub.io
if: steps.check_build.outputs.files_exists == 'true'
if: (steps.check_build.outputs.files_exists == 'true' && github.event.pull_request.head.repo.full_name == 'rdkcentral/firebolt-apis')
env:
GITHUB_TOKEN: ${{ secrets.SEMANTIC_RELEASE_BOT_PAT }} # <-- Allows semantic-release-bot to push changes to protected branches
npm_config_tag: ${{ env.NPM_DIST_TAG }} # <-- For main, this is `latest.` Otherwise, `next`, `next-major`, etc. See ./.releaserc for release branch config.
Expand Down
Loading
Loading